Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade more environments #8804

Merged
merged 3 commits into from
Nov 20, 2024
Merged

feat: upgrade more environments #8804

merged 3 commits into from
Nov 20, 2024

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Nov 20, 2024

About the changes

OSS info about more environments option
Screenshot 2024-11-20 at 11 35 24

Details:

  • upgrade components follow UpgradeFeatureName convention
  • using utm_source query param
  • dismissible content with local storage persistence

Important files

Discussion points

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 10:42am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2024 10:42am

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@@ -317,6 +318,7 @@ const ProjectEnvironmentList = () => {
/>
}
/>
{isOss() ? <UpgradeMoreEnvironments /> : null}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

show only to OSS

<Wrapper>
<MainContent>
<StyledImage
src={formatAssetPath(upgradeEnvironments)}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

making sure the asset works outside of localhost

@@ -0,0 +1,93 @@
import { Box, IconButton, Link, styled, Tooltip } from '@mui/material';
import upgradeEnvironments from 'assets/img/upgradeEnvironments.png';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

png was 30kb smaller than svg here

@kwasniew kwasniew merged commit 61df153 into main Nov 20, 2024
11 checks passed
@kwasniew kwasniew deleted the upgrade-more-environments branch November 20, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants